reproducibility issue with solidlsp bash-language-server and shellcheck

[alaestor]

Disclaimer: agent hit a bump and alerted me to a small problem.

Haven't looked too closely so I'm making this a discussion rather than opening an issue: there may be some configuration option that jumps over this path, but I didn't see one at a glance.

solidlsp appears to try and install bash-language-server and shellcheck even if they already exist on the system and are exposed in PATH. This complicates reproducibility and offline usage.

The agent fixed it for my usecase by applying a patch and repacking serena in a closure with the expected tooling.

If this is a mistake and there's a known workaround, please let me know because I wasn't able to find it by briefly searching issues/PR/disucssions.

If it is a problem, then it may likely effect other LSPs. A quick slop-audit:

• Yes. The same pattern appears widely.

  Clear single-executable candidates

  - ansible-language-server
  - intelephense
  - vscode-json-languageserver
  - some-sass-language-server
  - vscode-html-language-server
  - yaml-language-server
  - vtsls
  - marksman
  - texlab
  - terraform-ls
  - clojure-lsp
  - cue
  - dart
  - fsautocomplete

  These currently install/download managed copies without first checking PATH.

  More complicated candidates

  - TypeScript, Angular, Vue, and Svelte require coordinated TypeScript SDK/plugin paths.
  - Solidity also manages Forge.
  - Groovy, Kotlin, Java, C#, and PowerShell manage runtimes or multi-file distributions.
  - Ada and Kotlin already support explicit ls_path configuration, making PATH lookup less urgent.

  Already following the desired pattern

  Examples include clangd, rust-analyzer, nixd, lua-language-server, taplo, luau-lsp, ccls, Haxe,
  Elm, Scala/Metals, Ruby LSP, and several others.

[opcode81]

there may be some configuration option that jumps over this path

There is: https://oraios.github.io/serena/02-usage/050_configuration.html#customizing-the-language-server-launch-command
If you set ls_path for the bash language server in your global configuration, you can use any fixed version of the server you want.

This complicates reproducibility

From Serena's perspective, it is the exact opposite.
Only by using a fixed version of every language server can we ensure that the integration with Serena is tested, producing reproducible behaviour for users.

[alaestor]

Thank you!

It seems the problem is more narrowly scoped than I originally thought. I can direct the bash-lsp command to my supplied program, but serena seems to override SHELLCHECK_PATH to always point at its managed version; unless I'm missing something else again?

I'm able to work around this by just wrapping my bash-lsp to override the environment variable (much better than the invasive patch approach...)

[kaled001-star]

2 بال احالم خلف سالم العبودي هاشمية فرج 954053 1969
93 احالم سعدون خضير عباس سليمه غني 197169462937 1971
94 احالم عباس هادي زهرة عبيد العودة 844884 1958
95 احالم قاسم جاسم نورية زغير 7744150 1976
96 احالم نادر عبد القادر سليمة سلمان 195459477794 1954
97 احمد حسن علي فرج انتصارهادي 838260 1997
98 بال احمد يونس مرعي حسن قدرية حمدان عبد الرحمن 1968837309787 1968
99 احمد ابراهيم حسن نجية حديد 3135845 1985
100 احمد ابراهيم صالح نجمة احمد 827300 1956
101 اليوجد احمد ابراهيم محسن علوان الجبوري عواطف يوسف حيدر 00779161 1993
102 احمد ابراهيم ياسر الزرفي رصينه عبادي حمزة 090183933 1984
103 احمد ارحيم كريدي حسون بتول العيوس 177766 1982
104 51748783-2 احمد اسعد شالل نوفة علي لطيف 197331927752 1973
105 احمد اسماعيل كاظم فهيمة علي 199570966000 1995
106 احمد امجد جواد فليحة حسن 198748399248 1987
107 احمد امجد مهدي ايناس علي عبد 199639778157 1996
108 مفقودة احمد امين امين احالم عبادي 440795 1986
109 احمد اوات احمد سهير 1982
110 احمد اياد عباس احمد هاشم 112671 1991
111 احمد اياد مهدي جاسم فاضل 735173 1995
112 احمد باقر عبد كردي المجالوي فاطمة مجلي 199072499615 5/7/1990
113 احمد ثابت فيصل مردان سحر عبد االمير سلطان 199037051362 1990
114 احمد ثامر علوان زيدان هناء حسين 199450326278 1994
115 احمد ثامر عبد الرحمن تركيه جاسم 88411 1978
116 احمد جاسم خليل ابراهيم عزيزة حسن 199089607331 1990
117 احمد جاسم ذياب نكوة صبار 196258270933 1962
118 احمد جاسم سعدية حيدر 197699950135 1976
119 احمد جاسم حسين العبيدي تركية عبد علي 198865228287 1988
120 169953 احمد جاسم عباس بهية سليمة سلمان عباس 544063 1979
121 51584391-3 احمد جبار خلف جبير صخيلة