From 0b96dc73fa275cb8231e20a7802f9e7f9d10f951 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Thu, 30 Jun 2016 00:17:52 +0200 Subject: [PATCH] src: fix use-after-free in v8 inspector AgentImp::OnInspectorHandshakeIO() should not delete the socket because its caller, data_received_cb(), takes care of that. --- src/inspector_agent.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 8ef95305a6f3..9533372c1f3b 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -417,7 +417,6 @@ bool AgentImpl::OnInspectorHandshakeIO(inspector_socket_t* socket, agent->OnInspectorConnectionIO(socket); return true; case kInspectorHandshakeFailed: - delete socket; return false; default: UNREACHABLE();