test: use shorthand properties

PR-URL: #18105
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: tniessen

test/fixtures/tls-connect.js

@@ -44,10 +44,7 @@ exports.connect = function connect(options, callback) {
 
   const server = {};
   const client = {};
-  const pair = {
-    server: server,
-    client: client,
-  };
+  const pair = { server, client };
 
   tls.createServer(options.server, function(conn) {
     server.conn = conn;

test/internet/test-tls-reuse-host-from-socket.js

@@ -30,7 +30,7 @@ const tls = require('tls');
 const net = require('net');
 
 const socket = net.connect(443, 'www.example.org', common.mustCall(() => {
-  const secureSocket = tls.connect({ socket: socket }, common.mustCall(() => {
+  const secureSocket = tls.connect({ socket }, common.mustCall(() => {
     secureSocket.destroy();
     console.log('ok');
   }));

test/parallel/test-child-process-env.js

@@ -35,10 +35,10 @@ Object.setPrototypeOf(env, {
 let child;
 if (common.isWindows) {
   child = spawn('cmd.exe', ['/c', 'set'],
-                Object.assign({}, process.env, { env: env }));
+                Object.assign({}, process.env, { env }));
 } else {
   child = spawn('/usr/bin/env', [],
-                Object.assign({}, process.env, { env: env }));
+                Object.assign({}, process.env, { env }));
 }
 
 

test/parallel/test-cluster-dgram-1.js

@@ -102,7 +102,7 @@ function worker() {
 
     // Every 10 messages, notify the master.
     if (received === PACKETS_PER_WORKER) {
-      process.send({ received: received });
+      process.send({ received });
       socket.close();
     }
   }, PACKETS_PER_WORKER));

test/parallel/test-cluster-worker-no-exit.js

@@ -60,7 +60,7 @@ if (cluster.isMaster) {
 
     worker = cluster.fork()
       .on('online', function() {
-        this.send({ port: port });
+        this.send({ port });
       });
   });
   process.on('exit', function() {

test/parallel/test-fs-realpath-buffer-encoding.js

@@ -21,13 +21,13 @@ for (encoding in expected) {
   const expected_value = expected[encoding];
   let result;
 
-  result = fs.realpathSync(string_dir, { encoding: encoding });
+  result = fs.realpathSync(string_dir, { encoding });
   assert.strictEqual(result, expected_value);
 
   result = fs.realpathSync(string_dir, encoding);
   assert.strictEqual(result, expected_value);
 
-  result = fs.realpathSync(buffer_dir, { encoding: encoding });
+  result = fs.realpathSync(buffer_dir, { encoding });
   assert.strictEqual(result, expected_value);
 
   result = fs.realpathSync(buffer_dir, encoding);
@@ -53,7 +53,7 @@ for (encoding in expected) {
 
   fs.realpath(
     string_dir,
-    { encoding: encoding },
+    { encoding },
     common.mustCall((err, res) => {
       assert.ifError(err);
       assert.strictEqual(res, expected_value);
@@ -65,7 +65,7 @@ for (encoding in expected) {
   }));
   fs.realpath(
     buffer_dir,
-    { encoding: encoding },
+    { encoding },
     common.mustCall((err, res) => {
       assert.ifError(err);
       assert.strictEqual(res, expected_value);

test/parallel/test-fs-write-file-sync.js

@@ -51,7 +51,7 @@ common.refreshTmpDir();
 // Test writeFileSync
 const file1 = path.join(common.tmpDir, 'testWriteFileSync.txt');
 
-fs.writeFileSync(file1, '123', { mode: mode });
+fs.writeFileSync(file1, '123', { mode });
 
 content = fs.readFileSync(file1, { encoding: 'utf8' });
 assert.strictEqual(content, '123');
@@ -61,7 +61,7 @@ assert.strictEqual(fs.statSync(file1).mode & 0o777, mode);
 // Test appendFileSync
 const file2 = path.join(common.tmpDir, 'testAppendFileSync.txt');
 
-fs.appendFileSync(file2, 'abc', { mode: mode });
+fs.appendFileSync(file2, 'abc', { mode });
 
 content = fs.readFileSync(file2, { encoding: 'utf8' });
 assert.strictEqual(content, 'abc');

test/parallel/test-http-client-read-in-error.js

@@ -34,7 +34,7 @@ class Agent extends http.Agent {
 const agent = new Agent();
 
 http.request({
-  agent: agent
+  agent
 }).once('error', function() {
   console.log('ignore');
 });

test/parallel/test-http-pipeline-flood.js

@@ -66,7 +66,7 @@ function child() {
   const net = require('net');
 
   const port = +process.argv[3];
-  const conn = net.connect({ port: port });
+  const conn = net.connect({ port });
 
   let req = `GET / HTTP/1.1\r\nHost: localhost:${port}\r\nAccept: */*\r\n\r\n`;
 

test/parallel/test-http2-create-client-connect.js

@@ -22,8 +22,8 @@ const URL = url.URL;
       [`http://localhost:${port}`],
       [new URL(`http://localhost:${port}`)],
       [url.parse(`http://localhost:${port}`)],
-      [{ port: port }, { protocol: 'http:' }],
-      [{ port: port, hostname: '127.0.0.1' }, { protocol: 'http:' }]
+      [{ port }, { protocol: 'http:' }],
+      [{ port, hostname: '127.0.0.1' }, { protocol: 'http:' }]
     ];
 
     const serverClose = new Countdown(items.length + 1,