diff --git a/news/3 Code Health/1551.md b/news/3 Code Health/1551.md new file mode 100644 index 000000000000..22d188323ffb --- /dev/null +++ b/news/3 Code Health/1551.md @@ -0,0 +1 @@ +Remove unused setting `disablePromptForFeatures`. diff --git a/package.json b/package.json index e2a93ec80a2c..20bd94e11ba6 100644 --- a/package.json +++ b/package.json @@ -1156,26 +1156,6 @@ "description": "Whether to check if Python is installed (also warn when using the macOS-installed Python).", "scope": "resource" }, - "python.disablePromptForFeatures": { - "type": "array", - "default": [], - "description": "Do not display a prompt to install these features", - "items": { - "type": "string", - "default": "pylint", - "description": "Feature", - "enum": [ - "flake8", - "mypy", - "pep8", - "pylama", - "prospector", - "pydocstyle", - "pylint" - ] - }, - "scope": "resource" - }, "python.envFile": { "type": "string", "description": "Absolute path to a file containing environment variable definitions.", diff --git a/src/client/common/configSettings.ts b/src/client/common/configSettings.ts index 99c111d64f70..a55c4b8bd397 100644 --- a/src/client/common/configSettings.ts +++ b/src/client/common/configSettings.ts @@ -29,7 +29,6 @@ export class PythonSettings extends EventEmitter implements IPythonSettings { public jediPath = ''; public jediMemoryLimit = 1024; public envFile = ''; - public disablePromptForFeatures: string[] = []; public venvPath = ''; public venvFolders: string[] = []; public devOptions: string[] = []; @@ -136,9 +135,6 @@ export class PythonSettings extends EventEmitter implements IPythonSettings { // tslint:disable-next-line:no-backbone-get-set-outside-model no-non-null-assertion const lintingSettings = systemVariables.resolveAny(pythonSettings.get('linting'))!; - // tslint:disable-next-line:no-backbone-get-set-outside-model no-non-null-assertion - this.disablePromptForFeatures = pythonSettings.get('disablePromptForFeatures')!; - this.disablePromptForFeatures = Array.isArray(this.disablePromptForFeatures) ? this.disablePromptForFeatures : []; if (this.linting) { Object.assign(this.linting, lintingSettings); } else { diff --git a/src/client/common/types.ts b/src/client/common/types.ts index 240b6f5809e3..f11581bf1ca3 100644 --- a/src/client/common/types.ts +++ b/src/client/common/types.ts @@ -110,7 +110,6 @@ export interface IPythonSettings { readonly sortImports?: ISortImportSettings; readonly workspaceSymbols?: IWorkspaceSymbolSettings; readonly envFile: string; - readonly disablePromptForFeatures: string[]; readonly disableInstallationChecks: boolean; readonly globalModuleInstallation: boolean; }