From 718e81adcbe12eb7e379b494dcffa7a5f264b7c5 Mon Sep 17 00:00:00 2001 From: muneer320 Date: Thu, 12 Nov 2026 18:41:12 +0530 Subject: [PATCH 1/2] fix(abstractions): preserve datetime fold in request parameters --- .../kiota_abstractions/request_information.py | 6 +----- packages/abstractions/requirements-dev.txt | 1 + .../tests/test_request_information.py | 17 +++++++++++++++++ 3 files changed, 19 insertions(+), 5 deletions(-) diff --git a/packages/abstractions/kiota_abstractions/request_information.py b/packages/abstractions/kiota_abstractions/request_information.py index 1c1123c0..e99a15d0 100644 --- a/packages/abstractions/kiota_abstractions/request_information.py +++ b/packages/abstractions/kiota_abstractions/request_information.py @@ -315,11 +315,7 @@ def _get_sanitized_value(self, value: Any) -> Any: sanitized_value = value if isinstance(value, datetime): timezone_info = value.tzinfo if value.tzinfo is not None else timezone.utc - temp_date_with_tz_info = datetime( - value.year, value.month, value.day, value.hour, value.minute, value.second, - value.microsecond, timezone_info - ) - sanitized_value = temp_date_with_tz_info.isoformat("T") + sanitized_value = value.replace(tzinfo=timezone_info).isoformat("T") elif isinstance(value, (UUID, date, time)): sanitized_value = str(value) return sanitized_value diff --git a/packages/abstractions/requirements-dev.txt b/packages/abstractions/requirements-dev.txt index 25566ec4..7ab33186 100644 --- a/packages/abstractions/requirements-dev.txt +++ b/packages/abstractions/requirements-dev.txt @@ -5,3 +5,4 @@ pylint>=4.1.3,<5.0.0 mypy>=2.4.1,<3.0.0 pytest>=9.2.0,<10.0.0 pytest-asyncio>=1.4.1.post1,<1.5 +tzdata>=2020.1 diff --git a/packages/abstractions/tests/test_request_information.py b/packages/abstractions/tests/test_request_information.py index 3f5a6777..b7a25783 100644 --- a/packages/abstractions/tests/test_request_information.py +++ b/packages/abstractions/tests/test_request_information.py @@ -2,7 +2,9 @@ from dataclasses import dataclass from datetime import datetime from typing import Optional +from urllib.parse import parse_qs, unquote, urlsplit from unittest.mock import Mock +from zoneinfo import ZoneInfo import pytest @@ -262,6 +264,21 @@ def test_sets_datetime_values_in_path_parameters(): assert request_info.url == "https://example.com/daysFrom/2020-08-01T00%3A20%3A00%2B00%3A00" +@pytest.mark.parametrize("fold", [0, 1]) +@pytest.mark.parametrize("location", ["path", "query", "query_collection"]) +def test_datetime_parameters_preserve_fold(fold, location): + value = datetime(2020, 11, 1, 1, 30, tzinfo=ZoneInfo("America/New_York"), fold=fold) + if location == "path": + request_info = RequestInformation(Method.GET, "https://example.com/events/{at}") + request_info.path_parameters["at"] = value + actual = unquote(urlsplit(request_info.url).path).rsplit("/", 1)[-1] + else: + request_info = RequestInformation(Method.GET, "https://example.com/events{?at}") + request_info.query_parameters["at"] = [value] if location == "query_collection" else value + actual = parse_qs(urlsplit(request_info.url).query)["at"][0] + assert actual == value.isoformat() + + def test_sets_int_values_in_path_parameters(): """Tests setting int values values in path parameters """ From cda2785c62a1be8c47c0942361909bdcf1c05a31 Mon Sep 17 00:00:00 2001 From: muneer320 Date: Fri, 13 Nov 2026 02:03:03 +0530 Subject: [PATCH 2/2] test(abstractions): explain and update timezone data requirement --- packages/abstractions/requirements-dev.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/abstractions/requirements-dev.txt b/packages/abstractions/requirements-dev.txt index 7ab33186..928b396a 100644 --- a/packages/abstractions/requirements-dev.txt +++ b/packages/abstractions/requirements-dev.txt @@ -5,4 +5,5 @@ pylint>=4.1.3,<5.0.0 mypy>=2.4.1,<3.0.0 pytest>=9.2.0,<10.0.0 pytest-asyncio>=1.4.1.post1,<1.5 -tzdata>=2020.1 +# Supply ZoneInfo data for the DST tests on systems without an IANA database. +tzdata>=2026.6