From f1af711dc0fdc79c9e0d0bf112789e1473c606fc Mon Sep 17 00:00:00 2001 From: muneer320 Date: Sat, 7 Nov 2026 20:25:02 +0530 Subject: [PATCH] fix(text): serialize falsy enum values --- .../text_serialization_writer.py | 2 +- .../unit/test_text_serialization_writer.py | 23 +++++++++++++++++++ 2 files changed, 24 insertions(+), 1 deletion(-) diff --git a/packages/serialization/text/kiota_serialization_text/text_serialization_writer.py b/packages/serialization/text/kiota_serialization_text/text_serialization_writer.py index 2d5deba7..22ea2624 100644 --- a/packages/serialization/text/kiota_serialization_text/text_serialization_writer.py +++ b/packages/serialization/text/kiota_serialization_text/text_serialization_writer.py @@ -177,7 +177,7 @@ def write_enum_value(self, key: Optional[str], value: Optional[K]) -> None: key (Optional[str]): The key to be used for the written value. May be null. value (Optional[K]): The enum value to be written. """ - if value: + if value is not None: self.write_str_value(key, str(value.value)) def write_null_value(self, key: Optional[str]) -> None: diff --git a/packages/serialization/text/tests/unit/test_text_serialization_writer.py b/packages/serialization/text/tests/unit/test_text_serialization_writer.py index dc46c900..954b1418 100644 --- a/packages/serialization/text/tests/unit/test_text_serialization_writer.py +++ b/packages/serialization/text/tests/unit/test_text_serialization_writer.py @@ -1,4 +1,5 @@ from uuid import UUID +from enum import Enum, IntEnum, IntFlag import pytest from datetime import date, datetime, timedelta @@ -220,6 +221,28 @@ def test_write_enum_value(): assert content_string == "dunhill" +@pytest.mark.parametrize("enum_type", [IntEnum, IntFlag]) +def test_write_falsy_enum_value(enum_type): + value = enum_type("State", {"None_": 0}).None_ + writer = TextSerializationWriter() + writer.write_enum_value(None, value) + assert writer.get_serialized_content() == b"0" + + +def test_write_falsy_string_enum_value(): + value = Enum("State", {"Empty": ""}, type=str).Empty + writer = TextSerializationWriter() + writer.write_enum_value(None, value) + assert writer.get_serialized_content() == b"" + + +def test_write_none_enum_value_is_ignored(): + writer = TextSerializationWriter() + writer.write_enum_value(None, None) + writer.write_str_value(None, "later") + assert writer.get_serialized_content() == b"later" + + def test_write_enum_value_with_key(): with pytest.raises(Exception) as e_info: text_serialization_writer = TextSerializationWriter()