From aaf9102e4879ae44fb20fd03cbb27f2302bf121d Mon Sep 17 00:00:00 2001 From: arjunyel Date: Mon, 6 Mar 2017 21:23:52 -0600 Subject: [PATCH 1/3] Fixes DocumentFragment DOM bug --- baselines/dom.generated.d.ts | 1 + inputfiles/addedTypes.json | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index b303baf18..5bd1e5129 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -3450,6 +3450,7 @@ declare var Document: { } interface DocumentFragment extends Node, NodeSelector, ParentNode { + getElementById(): Element | null; } declare var DocumentFragment: { diff --git a/inputfiles/addedTypes.json b/inputfiles/addedTypes.json index 5489332f8..04c7c8565 100644 --- a/inputfiles/addedTypes.json +++ b/inputfiles/addedTypes.json @@ -1444,5 +1444,12 @@ "name": "formData", "flavor": "Web", "signatures": ["formData(): Promise"] + }, + { + "kind": "method", + "interface": "DocumentFragment", + "name": "getElementById", + "flavor": "DOM", + "signatures": ["getElementById(): Element | null"] } ] From c941fe17e0c3d27988bfcb8ca7d2269dcc8cb300 Mon Sep 17 00:00:00 2001 From: arjunyel Date: Tue, 7 Mar 2017 00:36:30 -0600 Subject: [PATCH 2/3] Fixed signature --- baselines/dom.generated.d.ts | 2 +- inputfiles/addedTypes.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 5bd1e5129..2c2c61da3 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -3450,7 +3450,7 @@ declare var Document: { } interface DocumentFragment extends Node, NodeSelector, ParentNode { - getElementById(): Element | null; + getElementById(elementId: string): Element | null; } declare var DocumentFragment: { diff --git a/inputfiles/addedTypes.json b/inputfiles/addedTypes.json index 04c7c8565..4fc0d20b0 100644 --- a/inputfiles/addedTypes.json +++ b/inputfiles/addedTypes.json @@ -1450,6 +1450,6 @@ "interface": "DocumentFragment", "name": "getElementById", "flavor": "DOM", - "signatures": ["getElementById(): Element | null"] + "signatures": ["getElementById(elementId: string): Element | null"] } ] From efbd70a9bf5db369043ba0b026c4489ca88060c9 Mon Sep 17 00:00:00 2001 From: arjunyel Date: Tue, 7 Mar 2017 00:50:13 -0600 Subject: [PATCH 3/3] More consistent to document method --- baselines/dom.generated.d.ts | 2 +- inputfiles/addedTypes.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/baselines/dom.generated.d.ts b/baselines/dom.generated.d.ts index 2c2c61da3..056f4a02a 100644 --- a/baselines/dom.generated.d.ts +++ b/baselines/dom.generated.d.ts @@ -3450,7 +3450,7 @@ declare var Document: { } interface DocumentFragment extends Node, NodeSelector, ParentNode { - getElementById(elementId: string): Element | null; + getElementById(elementId: string): HTMLElement | null; } declare var DocumentFragment: { diff --git a/inputfiles/addedTypes.json b/inputfiles/addedTypes.json index 4fc0d20b0..a1d7f851d 100644 --- a/inputfiles/addedTypes.json +++ b/inputfiles/addedTypes.json @@ -1450,6 +1450,6 @@ "interface": "DocumentFragment", "name": "getElementById", "flavor": "DOM", - "signatures": ["getElementById(elementId: string): Element | null"] + "signatures": ["getElementById(elementId: string): HTMLElement | null"] } ]