Repository navigation
fix: guide agents to quote the fixlab exec separator and avoid cmd /c - #61
Merged
Merged
Conversation
In Windows PowerShell an unquoted -- is dropped, so fixlab exec printed usage and agents fell back to a cmd /c wrapper that non-interactive sessions deny. Update agent guidance, the dashboard prompt and troubleshooting docs, and add a hint to the usage error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aa2b2938-9ca6-4b67-a11a-f131b554d603
There was a problem hiding this comment.
🟡 Changes recommended
The direct CLI guidance remains unsynchronized, and the troubleshooting page still presents the broken invocation first.
2 open findings
What changed in this PR
Adds Windows PowerShell guidance for reliably invoking fixlab exec.
Changes:
- Documents quoting the
--separator and avoidingcmd /c. - Adds these instructions to agent and dashboard prompts.
- Extends usage-error and dashboard prompt tests.
| File | Description |
|---|---|
bin/structured-command.js |
Adds PowerShell troubleshooting hints. |
dashboard/server.js |
Adds guidance to dashboard prompts. |
agents/fixlab.md |
Updates the Agency agent instructions. |
com.github.copilot/agents/fixlab.agent.md |
Mirrors packaged agent guidance. |
templates/fixlab-autofix.agent.md |
Updates initialized agent guidance. |
.github/agents/fixlab-autofix.agent.md |
Updates the versioned autofix agent. |
docs/troubleshooting.md |
Documents the PowerShell invocation workaround. |
test/structured-command.test.js |
Verifies usage-error hints. |
test/dashboard-server.test.js |
Verifies dashboard prompt guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - ${playwrightOnly ? "Skip source diagnosis, separate reproduction, implementation, diff review, and non-browser validation. Mark diagnosis, reproduce, fix, and review skipped with the reason Playwright-only mode was selected." : "Inspect the affected surface, implement the smallest required code when edits are allowed, and self-review the effective diff for correctness, scope, and unrelated changes."} | ||
| - ${playwrightOnly ? "Run only setup commands strictly required to launch the profile-defined applications and focused Playwright journey. Do not reinstall dependencies that are already available." : "Run the focused repository-owned tests, type-checks, and builds needed for the affected surface and risk. Preserve exact results."} | ||
| - Run verbose repository-owned tests, builds, linters, type checks, and package validation through \`fixlab exec --stage <stage> -- <command> [args...]\`. Keep its compact result in context and inspect the private evidence path only when an exact diagnostic is needed. | ||
| - Run verbose repository-owned tests, builds, linters, type checks, and package validation through \`fixlab exec --stage <stage> -- <command> [args...]\`. In Windows PowerShell quote the separator (\`'--'\`) because an unquoted \`--\` is dropped, and never wrap \`fixlab exec\` in \`cmd /c\`; that wrapper is denied in non-interactive sessions. Keep its compact result in context and inspect the private evidence path only when an exact diagnostic is needed. |
Comment on lines
+15
to
+18
| In Windows PowerShell an unquoted `--` is dropped, so `fixlab exec` prints its | ||
| usage text instead of running. Quote the separator (`'--'`). Do not wrap the | ||
| command in `cmd /c`: the wrapper is denied when no interactive user can approve | ||
| it, which blocks the job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents on Windows PowerShell lost the unquoted -- separator, saw fixlab exec usage text, and fell back to cmd /c, which non-interactive sessions deny (blocked Bug 17296117 at reproduce). Updates all agent guidance copies, the dashboard prompt and docs\troubleshooting.md, adds a hint to the usage error, and extends tests. 131 tests, lint, tsc and docs check pass; format:check flags only mcp\server.js (pre-existing).