Skip to content

Batch mutations size #4423

Closed
Closed

Description

@gremi64

Hi,
I'm currently using "batchWrite" and i was surprised to see that it's not currently possible to access the mutations_list's size. As it's limited to 500 mutations, we should be able to know the size :)

Environment details

  • OS: W10
  • Java version: 1.8_191
  • google-cloud-java version(s): 0.79.0-beta

Steps to reproduce

N/A

Stacktrace

N/A

Code snippet

var batch: WriteBatch = this.firestore.batch()
// batch.getMutationsSize() ?

External references such as API reference guides used

https://cloud.google.com/firestore/docs/manage-data/transactions#batched-writes

Any additional information below

I'll provide a simple pull request to do it, but i'm pretty sure you don't need me on this ;)
[EDIT] pull request provided

Regards,
Gremi

Activity

  1. gremi64 commented on Feb 1, 2019

    @gremi64
    Author

    I don't know how, but i manage to close this issue...

  2. reopened this on Feb 1, 2019
  3. added
    type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
    api: firestoreIssues related to the Firestore API.
    and removed
    triage meI really want to be triaged.
    on Feb 5, 2019
  4. added a commit that references this issue on Feb 8, 2019
    64f3b2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

api: firestoreIssues related to the Firestore API.type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions