From 99dc05c76ea80fb39c7713e7308586c120dd01d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Vogel?=
 <104342347+cedricvogel-leo@users.noreply.github.com>
Date: Mon, 26 Oct 2026 22:15:26 +0100
Subject: [PATCH] Define the shared code once in @onload instead of in every
 block
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

LiaScript expands a macro into every slide that uses it. With the whole
session logic in the run-once block, every glpython block added about 37k
characters, and slides with a choice quiz hung in Chrome when opened
directly (e.g. course/?…README.md#18): LiaScript's parser computes the
column against the original text, the expansions push it far past the end,
the quiz parser builds an indentation regex of ~39k spaces, and V8 throws
"Regular expression too large" (Safari's engine accepts it).

The session logic is now window.__glpythonMount in @onload. The run-once
block only passes its arguments and send; a block that runs before
@onload waits in window.__glpythonPending. One expansion is now ~3k
characters. check-macro also checks the @onload block.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 CLAUDE.md               |  2 +-
 README.md               | 69 +++++++++++++++++++++++++----------------
 scripts/check-macro.mjs |  7 ++++-
 3 files changed, 50 insertions(+), 28 deletions(-)

diff --git a/CLAUDE.md b/CLAUDE.md
index 5323b8d..e8731d6 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -4,7 +4,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
 
 ## What this is
 
-The LiaScript macro that embeds glpython in courses. `README.md` is both the documentation and the macro itself: its header comment defines `@GLPython.eval`, `@GLPython.turtle` and `@GLPython.visual` and holds two `<script>` blocks (the per-run block and a `run-once` block with the session logic). Courses import it from `main`:
+The LiaScript macro that embeds glpython in courses. `README.md` is both the documentation and the macro itself: its header comment defines `@GLPython.eval`, `@GLPython.turtle` and `@GLPython.visual` and holds the session logic in `@onload` (`window.__glpythonMount`, run once per course) plus two `<script>` blocks (the per-run block and a short `run-once` block that only passes the block's arguments to `__glpythonMount`). Keep the code in `@onload`, not in the macro: LiaScript expands a macro into every slide that uses it, and long expansions break slides in Chrome (`Regular expression too large`, when a slide with a choice quiz is opened directly; cause: the column LiaScript's parser computes after a macro expansion). Courses import it from `main`:
 
 ```
 import: https://raw.githubusercontent.com/glpython-edu/glpython-liascript/main/README.md
diff --git a/README.md b/README.md
index 1f2bc80..b563493 100644
--- a/README.md
+++ b/README.md
@@ -13,41 +13,26 @@ comment:  Embed the glpython editor, execution visualizer, and turtle graphics
 
 @GLPython.visual: @GLPython.embed(@uid,visual,@0,@1,@2,@3,@4,@5,@6,@7)
 
-@GLPython.embed
-<script>
-(() => {
-  const session = window.__glpythonSessions?.get("@0")
-  const source = "@'input"
-  if (!session) {
-    const primary = (tag) => (tag || "").toLowerCase().split("-")[0]
-    const german = [primary(document.documentElement.lang), primary(navigator.language)].find((language) => ["de", "en"].includes(language)) === "de"
-    const message = german
-      ? "Die glpython-Laufzeit ist noch nicht bereit."
-      : "The glpython runtime is not ready."
-    send.lia(`HTML: <pre style='color:red'>${message}</pre>`)
-    return
-  }
-  session.run(source)
-  window.setTimeout(() => send.lia("LIA: stop"), 0)
-})()
-
-"LIA: wait"
-</script>
-
-<script run-once>
-(() => {
+@onload
+// The shared code of every glpython block, defined once per course. The
+// macro's own run-once block only passes its arguments: LiaScript expands a
+// macro into the slide, and the whole code in every block made slides so long
+// that Chrome failed on them (LiaScript then builds a regular expression from
+// a wrong column; it happened when a slide with several blocks and a choice
+// quiz was opened directly). Blocks that run before this code wait in
+// window.__glpythonPending.
+window.__glpythonMount = (args, send) => {
   const protocolVersion = 4
   const embedOrigin = "https://glpython-edu.github.io"
   const embedUrl = `${embedOrigin}/glpython-editor/index.html`
-  const sessionId = "@0"
-  const mode = "@1"
+  const [sessionId, mode, ...optionArguments] = args
   // Optional per block, separated by spaces in any order: "box" or
   // "substitution" presets the visualizer's mode, and URLs of shared Python
   // files to load as libraries, e.g. @GLPython.eval(box https://…/parser.py).
   // LiaScript splits macro arguments at commas, so "features=run,repl" arrives
   // as several arguments: they are joined back together here. Arguments that
   // weren't given stay literal ("@3") and are left out.
-  const options = ["@2", "@3", "@4", "@5", "@6", "@7", "@8", "@9"]
+  const options = optionArguments
     .filter((argument) => !/^@[0-9]$/.test(argument))
     .join(",")
     .split(/\s+/)
@@ -683,6 +668,38 @@ comment:  Embed the glpython editor, execution visualizer, and turtle graphics
   window.addEventListener("message", onMessage)
   new MutationObserver(attach).observe(document.body, { childList: true, subtree: true })
   attach()
+}
+for (const mount of window.__glpythonPending ?? []) mount()
+window.__glpythonPending = []
+@end
+
+@GLPython.embed
+<script>
+(() => {
+  const session = window.__glpythonSessions?.get("@0")
+  const source = "@'input"
+  if (!session) {
+    const primary = (tag) => (tag || "").toLowerCase().split("-")[0]
+    const german = [primary(document.documentElement.lang), primary(navigator.language)].find((language) => ["de", "en"].includes(language)) === "de"
+    const message = german
+      ? "Die glpython-Laufzeit ist noch nicht bereit."
+      : "The glpython runtime is not ready."
+    send.lia(`HTML: <pre style='color:red'>${message}</pre>`)
+    return
+  }
+  session.run(source)
+  window.setTimeout(() => send.lia("LIA: stop"), 0)
+})()
+
+"LIA: wait"
+</script>
+
+<script run-once>
+(() => {
+  // The code itself is in @onload, see there.
+  const mount = () => window.__glpythonMount(["@0", "@1", "@2", "@3", "@4", "@5", "@6", "@7", "@8", "@9"], send)
+  if (window.__glpythonMount) mount()
+  else (window.__glpythonPending ??= []).push(mount)
 })()
 
 "LIA: wait"
diff --git a/scripts/check-macro.mjs b/scripts/check-macro.mjs
index f7b061e..2710dbf 100644
--- a/scripts/check-macro.mjs
+++ b/scripts/check-macro.mjs
@@ -15,6 +15,11 @@ const blocks = [...readme.matchAll(/<script\b[^>]*>([\s\S]*?)<\/script>/g)].map(
   code: match[1],
   line: readme.slice(0, match.index).split('\n').length,
 }))
+// The shared code in @onload, which LiaScript runs once per course as written.
+// Its first line is the one with @onload, like <script> above.
+for (const match of readme.matchAll(/^@onload\n([\s\S]*?)\n@end$/gm)) {
+  blocks.push({ code: `\n${match[1]}`, line: readme.slice(0, match.index).split('\n').length })
+}
 if (blocks.length === 0) {
   console.error('No <script> blocks found in README.md.')
   process.exit(1)
@@ -43,4 +48,4 @@ for (const [index, block] of blocks.entries()) {
   }
 }
 if (failed > 0) process.exit(1)
-console.log(`Macro check passed: ${blocks.length} <script> blocks.`)
+console.log(`Macro check passed: ${blocks.length} blocks (<script> and @onload).`)