From dff26f6f96576efcf8702d5238be5abfe964e9b6 Mon Sep 17 00:00:00 2001 From: "Dina Berry (She/her)" Date: Tue, 7 Apr 2026 08:45:30 -0700 Subject: [PATCH 1/3] docs: add contributor-to-core-team handoff process in CONTRIBUTING.md External contributors can't use "Fix with Copilot" on review comments (requires write access). Document the explicit handoff flow: - Contributor: CI green + undraft + accept Copilot suggestions - Core team: address remaining Copilot issues, review, merge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- CONTRIBUTING.md | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index d64591dbc..a5ba1f4d5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -151,10 +151,32 @@ The Co-authored-by trailer is **required** for all commits (added by Copilot CLI 1. Add a changeset: `npx changeset add` (required before PR — see Changesets section) 2. Push your branch: `git push origin {yourusername}/217-readme-help-update` -3. Create a PR with explicit base and head: `gh pr create --base dev --repo bradygaster/squad --head {yourusername}:your-branch` +3. Create a PR **as a draft**: `gh pr create --draft --base dev --repo bradygaster/squad --head {yourusername}:your-branch` 4. Link the issue: Add `Closes #217` to PR description -5. Wait for CI checks to pass -6. Request review from the team (agents will respond via comments) +5. Work on your changes until CI passes and you're satisfied +6. **Mark as "Ready for review"** — this is the handoff signal to the core team (see below) + +### Handoff: Contributor → Core Team + +External contributors don't have write access, so the review-to-merge flow has a handoff point. Here's exactly what happens: + +**Your side (contributor):** + +1. ✅ All CI checks are green (build, test, lint, changeset) +2. ✅ PR is no longer a draft — mark as **"Ready for review"** +3. ✅ Copilot reviewer bot posts its review automatically +4. ✅ Accept any Copilot suggestions you agree with (you have permission to accept suggestions) +5. ✅ If Copilot flags issues you can't resolve via suggestions, note them in a PR comment + +> **Note:** You may see a "Fix with Copilot" button on review comments — this requires repo write access and won't work for external contributors. Use "Accept suggestion" instead, or leave a comment explaining why you disagree. + +**Core team side (after you undraft):** + +1. Look for CI-green, undrafted PRs from contributors +2. Address any remaining Copilot review issues (using "Fix with Copilot" or manual fixes) +3. Human review, resolve threads, and merge + +**TL;DR:** Your job is done when the PR is undrafted, CI is green, and you've responded to Copilot suggestions. The core team takes it from there. ### PR Readiness Checklist From 7979cf8a219b23450c602a265cd9b343d6cd229e Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Tue, 7 Apr 2026 16:18:26 +0000 Subject: [PATCH 2/3] docs: clarify changeset CI check is conditional on SDK/CLI source changes Agent-Logs-Url: https://github.com/bradygaster/squad/sessions/d6374ed4-60de-4839-b33f-0ba5b311ec81 Co-authored-by: diberry <41597107+diberry@users.noreply.github.com> --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a5ba1f4d5..ea7faaa6b 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -162,7 +162,7 @@ External contributors don't have write access, so the review-to-merge flow has a **Your side (contributor):** -1. ✅ All CI checks are green (build, test, lint, changeset) +1. ✅ All required CI checks are green (build, test, lint; changeset/CHANGELOG gate only applies when `packages/squad-cli/src/` or `packages/squad-sdk/src/` files change) 2. ✅ PR is no longer a draft — mark as **"Ready for review"** 3. ✅ Copilot reviewer bot posts its review automatically 4. ✅ Accept any Copilot suggestions you agree with (you have permission to accept suggestions) From 71a9ce32d40b2eefef8547f8f4c412bd66055f13 Mon Sep 17 00:00:00 2001 From: "Dina Berry (She/her)" Date: Tue, 7 Apr 2026 09:41:44 -0700 Subject: [PATCH 3/3] docs: fix misleading Copilot suggestion permissions claim MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit External fork contributors cannot use "Commit suggestion" or "Fix with Copilot" buttons — both require write access. Updated to say "manually apply in your fork and push" which is the actual workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- CONTRIBUTING.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index ea7faaa6b..69004421e 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -165,10 +165,11 @@ External contributors don't have write access, so the review-to-merge flow has a 1. ✅ All required CI checks are green (build, test, lint; changeset/CHANGELOG gate only applies when `packages/squad-cli/src/` or `packages/squad-sdk/src/` files change) 2. ✅ PR is no longer a draft — mark as **"Ready for review"** 3. ✅ Copilot reviewer bot posts its review automatically -4. ✅ Accept any Copilot suggestions you agree with (you have permission to accept suggestions) -5. ✅ If Copilot flags issues you can't resolve via suggestions, note them in a PR comment +4. ✅ Review Copilot's suggestions and manually apply any you agree with in your fork +5. ✅ Push updates to your branch to address Copilot's feedback +6. ✅ If Copilot flags issues you can't resolve, note them in a PR comment -> **Note:** You may see a "Fix with Copilot" button on review comments — this requires repo write access and won't work for external contributors. Use "Accept suggestion" instead, or leave a comment explaining why you disagree. +> **Note:** Copilot review suggestions appear as comments, but the "Commit suggestion" and "Fix with Copilot" buttons require repo write access and won't work for external contributors. Review the suggestions, apply them manually in your fork, and push your changes. **Core team side (after you undraft):**