From 2af491a869b493347a02608e20cf8c64e23761f2 Mon Sep 17 00:00:00 2001 From: "Dina Berry (She/her)" Date: Sun, 29 Mar 2026 21:12:50 -0700 Subject: [PATCH] fix(ci): consolidate CI workarounds from #697 and #698 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Combines two CI fixes that both modify squad-ci.yml: - #697: Skip ./client export smoke test + streaming-chat sample (workaround for @github/copilot-sdk ESM bug — vscode-jsonrpc/node) - #698: Run existing patch-esm-imports.mjs after npm ci --ignore-scripts (proper fix — patches missing ESM extension at the source) Resolution: #698's approach (running the patch script) fixes the root cause, making #697's skip-based workaround unnecessary. The existing patch-esm-imports.mjs (added for issue #449) was already solving this problem but was skipped in CI because npm ci --ignore-scripts bypasses the postinstall hook that runs it. Both changes target the same workflow file and should ship together. Refs: #697, #698 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- .github/workflows/squad-ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/squad-ci.yml b/.github/workflows/squad-ci.yml index d3003bb92..5be0c225c 100644 --- a/.github/workflows/squad-ci.yml +++ b/.github/workflows/squad-ci.yml @@ -351,6 +351,7 @@ jobs: if: steps.flag.outputs.skip == 'false' && steps.label.outputs.skip != 'true' && steps.changes.outputs.skip != 'true' run: | npm ci --ignore-scripts + node packages/squad-cli/scripts/patch-esm-imports.mjs npm run build -w packages/squad-sdk - name: Build and test samples @@ -721,6 +722,7 @@ jobs: if: steps.flag.outputs.skip == 'false' && steps.label.outputs.skip != 'true' && steps.changes.outputs.skip != 'true' run: | npm ci --ignore-scripts + node packages/squad-cli/scripts/patch-esm-imports.mjs npm run build -w packages/squad-sdk - name: Smoke test all subpath exports