From 4f8b7b72bb729b9567c309d84b9108f2e56062a6 Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Fri, 20 Oct 2017 14:12:07 +0100 Subject: [PATCH 01/11] Update to NUnit.ConsoleRunner 3.7.0 --- scripts/Run-NUnit.ps1 | 8 ++++---- test/GitHub.UI.UnitTests/packages.config | 1 + 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/scripts/Run-NUnit.ps1 b/scripts/Run-NUnit.ps1 index 804696062d..24a49befee 100644 --- a/scripts/Run-NUnit.ps1 +++ b/scripts/Run-NUnit.ps1 @@ -22,8 +22,8 @@ Push-Location $rootDirectory $dll = "src\$Project\bin\$Configuration\$Project.dll" if ($AppVeyor) { - $nunitDirectory = Join-Path $rootDirectory packages\NUnit.Runners.2.6.4\tools - $consoleRunner = Join-Path $nunitDirectory nunit-console-x86.exe + $nunitDirectory = Join-Path $rootDirectory packages\NUnit.ConsoleRunner.3.7.0\tools + $consoleRunner = Join-Path $nunitDirectory nunit3-console.exe $args = "-noshadow", "-framework:net-4.5", "-exclude:Timings", $dll [object[]] $output = "$consoleRunner " + ($args -join " ") & $consoleRunner ($args | %{ "`"$_`"" }) @@ -31,8 +31,8 @@ if ($AppVeyor) { $host.SetShouldExit($LastExitCode) } } else { - $nunitDirectory = Join-Path $rootDirectory packages\NUnit.Runners.2.6.4\tools - $consoleRunner = Join-Path $nunitDirectory nunit-console-x86.exe + $nunitDirectory = Join-Path $rootDirectory packages\NUnit.ConsoleRunner.3.7.0\tools + $consoleRunner = Join-Path $nunitDirectory nunit3-console.exe $xml = Join-Path $rootDirectory "nunit-$Project.xml" $outputPath = [System.IO.Path]::GetTempFileName() diff --git a/test/GitHub.UI.UnitTests/packages.config b/test/GitHub.UI.UnitTests/packages.config index 7265b3ce6e..13411d720b 100644 --- a/test/GitHub.UI.UnitTests/packages.config +++ b/test/GitHub.UI.UnitTests/packages.config @@ -2,4 +2,5 @@ + \ No newline at end of file From f224cbd905743b45b4db87a7fd87d2dd211ceaef Mon Sep 17 00:00:00 2001 From: Jamie Cansdale Date: Fri, 20 Oct 2017 14:35:03 +0100 Subject: [PATCH 02/11] Update to NUnit 3.6.1 and NUnit3TestAdapter Recent version that doesn't require extensive code changes. --- .../TrackingCollectionTests.cs | 4 +-- .../TrackingCollectionTests.csproj | 27 +++++++------------ src/TrackingCollectionTests/packages.config | 6 ++--- .../GitHub.UI.UnitTests.csproj | 3 +++ 4 files changed, 17 insertions(+), 23 deletions(-) diff --git a/src/TrackingCollectionTests/TrackingCollectionTests.cs b/src/TrackingCollectionTests/TrackingCollectionTests.cs index e64f0166f6..a618744a9e 100644 --- a/src/TrackingCollectionTests/TrackingCollectionTests.cs +++ b/src/TrackingCollectionTests/TrackingCollectionTests.cs @@ -1980,7 +1980,7 @@ public void RemovingWithNoObservableSetThrows() } [Test] - public async void AddingBeforeSubscribingWorks() + public async Task AddingBeforeSubscribingWorks() { ITrackingCollection col = new TrackingCollection(Observable.Empty()); ReplaySubject done = new ReplaySubject(); @@ -1993,7 +1993,7 @@ public async void AddingBeforeSubscribingWorks() done.OnNext(t); if (++count == 2) done.OnCompleted(); - }, () => {}); + }, () => { }); await Observable.Timeout(done, TimeSpan.FromMilliseconds(500)); Assert.AreEqual(2, col.Count); diff --git a/src/TrackingCollectionTests/TrackingCollectionTests.csproj b/src/TrackingCollectionTests/TrackingCollectionTests.csproj index cb49396df4..03bc8132eb 100644 --- a/src/TrackingCollectionTests/TrackingCollectionTests.csproj +++ b/src/TrackingCollectionTests/TrackingCollectionTests.csproj @@ -1,5 +1,6 @@  + 14.0 12.0 @@ -42,26 +43,10 @@ - - ..\..\packages\NUnitTestAdapter.2.0.0\lib\nunit.core.dll - False - - - ..\..\packages\NUnitTestAdapter.2.0.0\lib\nunit.core.interfaces.dll - False - - - ..\..\packages\NUnit.2.6.4\lib\nunit.framework.dll + + ..\..\packages\NUnit.3.6.1\lib\net45\nunit.framework.dll True - - ..\..\packages\NUnitTestAdapter.2.0.0\lib\nunit.util.dll - False - - - ..\..\packages\NUnitTestAdapter.2.0.0\lib\NUnit.VisualStudio.TestAdapter.dll - False - ..\..\packages\Rx-Core.2.2.5-custom\lib\net45\System.Reactive.Core.dll @@ -151,6 +136,12 @@ + + + This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them. For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}. + + +