Skip to content

Remove null as possible key value in docblock - #76

Merged
robertdimarco merged 1 commit into
googleapis:masterfrom
akeeman:patch-1
Jun 16, 2016
Merged

robertdimarco merged 1 commit into
googleapis:masterfrom
akeeman:patch-1

Conversation

@akeeman

@akeeman akeeman commented Dec 30, 2015

Copy link
Copy Markdown

The docblock states that null is a possible value for $key, however, it clearly results in an exception.

The docblock states that null is a possible value for $key, however, it clearly results in an exception.
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 30, 2015
@akeeman

akeeman commented Dec 30, 2015

Copy link
Copy Markdown
Author

I signed it!

@robertdimarco
robertdimarco merged commit e72feba into googleapis:master Jun 16, 2016
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 15, 2026
Remove null as possible key value in docblock
Hectorhammett pushed a commit to googleapis/google-cloud-php that referenced this pull request Sep 16, 2026
Remove null as possible key value in docblock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no This human has *not* signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants