From dd7dbdc037124ac7a64b66a97468e13566919b13 Mon Sep 17 00:00:00 2001 From: Robert Miller Date: Tue, 7 May 2019 19:57:32 -0400 Subject: [PATCH 1/3] Changed based on review --- sshcode.go | 1 - 1 file changed, 1 deletion(-) diff --git a/sshcode.go b/sshcode.go index a31e3d8..2dcd5c5 100644 --- a/sshcode.go +++ b/sshcode.go @@ -187,7 +187,6 @@ func parseBindAddr(bindAddr string) (string, error) { if err != nil { return "", err } - return net.JoinHostPort(host, port), nil } From 3ae1d3070c01a2eb4143c4658b413b6c92b613ad Mon Sep 17 00:00:00 2001 From: Robert Miller Date: Tue, 7 May 2019 20:50:36 -0400 Subject: [PATCH 2/3] expose noOpen as no-open --- main.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/main.go b/main.go index bc0de4a..d8db144 100644 --- a/main.go +++ b/main.go @@ -37,6 +37,7 @@ type rootCmd struct { skipSync bool syncBack bool printVersion bool + noOpen bool bindAddr string sshFlags string } @@ -53,6 +54,7 @@ func (c *rootCmd) RegisterFlags(fl *flag.FlagSet) { fl.BoolVar(&c.skipSync, "skipsync", false, "skip syncing local settings and extensions to remote host") fl.BoolVar(&c.syncBack, "b", false, "sync extensions back on termination") fl.BoolVar(&c.printVersion, "version", false, "print version information and exit") + fl.BoolVar(&c.noOpen, "no-open", false, "do not open web browser") fl.StringVar(&c.bindAddr, "bind", "", "local bind address for ssh tunnel") fl.StringVar(&c.sshFlags, "ssh-flags", "", "custom SSH flags") } @@ -79,6 +81,7 @@ func (c *rootCmd) Run(fl *flag.FlagSet) { skipSync: c.skipSync, sshFlags: c.sshFlags, bindAddr: c.bindAddr, + noOpen: c.noOpen, syncBack: c.syncBack, }) From a498ae461d1896d93e5c0cc6ef3748eb01e54cf1 Mon Sep 17 00:00:00 2001 From: Robert Miller Date: Tue, 7 May 2019 20:54:08 -0400 Subject: [PATCH 3/3] added newline to not make it a change --- sshcode.go | 1 + 1 file changed, 1 insertion(+) diff --git a/sshcode.go b/sshcode.go index 2dcd5c5..a31e3d8 100644 --- a/sshcode.go +++ b/sshcode.go @@ -187,6 +187,7 @@ func parseBindAddr(bindAddr string) (string, error) { if err != nil { return "", err } + return net.JoinHostPort(host, port), nil }