Skip to content

Deprecated API transition guide. - #363

Merged
lholmquist merged 1 commit into
cloudevents:mainfrom
lholmquist:360-transition-documentation-for-deprecated
Dec 7, 2020
Merged

lholmquist merged 1 commit into
cloudevents:mainfrom
lholmquist:360-transition-documentation-for-deprecated

Conversation

@lholmquist

Copy link
Copy Markdown
Contributor

This adds a guide to show the transition of the deprecated API's of 3.2.0 .

We can also use this for future deprecations

Description

fixes #360

@lholmquist
lholmquist force-pushed the 360-transition-documentation-for-deprecated branch from 86059d3 to ad1659c Compare November 7, 2020 20:56
@lholmquist
lholmquist requested a review from grant November 7, 2020 20:57
@lholmquist
lholmquist requested a review from lance November 12, 2020 15:54

@lance lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a couple of small nits. Outside of that, we'll need to adjust this for #366. Overall, lgtm. Thanks - this was needed!

Comment thread API_TRANSITION_GUIDE.md Resolved
Comment thread API_TRANSITION_GUIDE.md Resolved
Comment thread API_TRANSITION_GUIDE.md Resolved
Comment thread API_TRANSITION_GUIDE.md Resolved
Comment thread API_TRANSITION_GUIDE.md Resolved
@lholmquist
lholmquist force-pushed the 360-transition-documentation-for-deprecated branch from c352047 to 9298f2e Compare November 20, 2020 16:03
@grant
grant removed their request for review December 2, 2020 06:00
@lholmquist
lholmquist force-pushed the 360-transition-documentation-for-deprecated branch 2 times, most recently from ef1d74a to ef31b68 Compare December 2, 2020 20:39
@lholmquist
lholmquist requested a review from lance December 2, 2020 20:41
@lholmquist

Copy link
Copy Markdown
Contributor Author

@lance mind give this another look see. If things are good, i will squash and fix that DCO error before merging

@lance lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @lholmquist!

Signed-off-by: Lucas Holmquist <lholmqui@redhat.com>
@lholmquist
lholmquist force-pushed the 360-transition-documentation-for-deprecated branch from ef31b68 to 2e7db49 Compare December 7, 2020 16:09
@lholmquist
lholmquist merged commit 79296a8 into cloudevents:main Dec 7, 2020
@lholmquist
lholmquist deleted the 360-transition-documentation-for-deprecated branch December 7, 2020 16:21
@lholmquist lholmquist mentioned this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transition doc for deprecated API's

2 participants