Repository navigation
feat(admin): trust and automation for operator console - #920
Merged
Merged
Conversation
Add audit log API and Trust UI, signed webhook events for probe/mirror/SSL, OpenTelemetry probe and mirror metrics, redacted diagnostics export, and manual NIP-66 probe from the admin console. Closes #919
🦋 Changeset detectedLatest commit: e572093 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
Coverage Report for CI Build 39590902899Coverage decreased (-0.4%) to 73.796%Details
Uncovered Changes
Coverage Regressions2 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
 [Medium impact] The changes since the previous review appear safe to merge.
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Wrap Redis dedupe in try/catch, enqueue before marking alerts sent, atomize probe transitions, allow clearing webhook secrets, and fix Trust 401 handling.
Reload cached script SHAs after Redis flushes scripts and isolate SSL expiry notifications from probe eval failures.
Avoid constructing an invalid Redis URL during admin login and settings updates when REDIS_* env vars are unset (e.g. unit test CI).
greptile-apps
Bot
dismissed
their stale review
October 21, 2026 11:17
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
cameri
approved these changes
Oct 21, 2026
cameri
added a commit
that referenced
this pull request
Oct 31, 2026
…ts scripts (#1003) Adds an integration scenario for #1002. ## What #1002 actually was The relay answered `HTTP 200`, accepted websocket upgrades, and never acknowledged another event after its Redis cache was restarted. The cause is that the relay issues `EVALSHA`, and Lua scripts live in the cache's memory, so every call after a restart answers `NOSCRIPT`. **The production failure was an old image, not missing code.** The retry landed on 2026-10-21 in #920 (`src/adapters/redis-adapter.ts`, `isNoScriptError` + a `scriptLoad` retry). The relay that failed was built 2026-09-03 from revision `3006eee3`, five minor releases behind `latest` (3.8.0, built 2026-10-24). So what was missing is proof, not a fix: the unit test stubs `evalSha`, which cannot catch a retry that stops working through the workers — the path that actually broke — and nothing exercised a real script cache. ## What this adds `test/integration/features/redis-script-cache/` — one scenario that publishes, runs `SCRIPT FLUSH` against the same Redis, and publishes twice more. `SCRIPT FLUSH` is the whole of a restart as far as the relay can tell, and it is deterministic: no container to restart, no reconnect to wait for. The `@script-cache` hook configures a message rate limit on purpose. Both limiters return early when `rateLimits` is empty, so a scenario without one would pass whether or not the fallback existed — the guard that makes this test mean something. ## Verification | run | state of the adapter | result | |---|---|---| | [41221855127](https://github.com/cameri/nostream/actions/runs/41221855127) | retry present | **Integration Tests: success** | | [41222446906](https://github.com/cameri/nostream/actions/runs/41222446906) | retry removed (probe commit) | **Integration Tests: failure**, Unit Tests: failure | | [41222894268](https://github.com/cameri/nostream/actions/runs/41222894268) | retry restored | **Integration Tests: success** | The middle row is the fail-before: the scenario goes red exactly when the fallback goes away, and green when it returns. The probe commit was dropped from the branch afterwards, so the diff here is the test and its changeset only. `cucumber-js --dry-run` over the full feature set reports 123 scenarios with no undefined steps. Refs #1002.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds :-
GET /admin/audit-log) and Trust UIRelated Issue
Closes #919
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Screen.Recording.2026-10-21.at.08.33.15.mov
Types of changes
Checklist: