From 0d6557c01131341e4a5099c340b0b7b46b562f1b Mon Sep 17 00:00:00 2001 From: Rafael da Fonseca Date: Sun, 14 Jun 2015 21:46:35 +0200 Subject: [PATCH 1/2] Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in RpcProviderImpl.java Assert isn't used in prod runtime --- .../src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java | 1 - 1 file changed, 1 deletion(-) diff --git a/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java b/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java index cc0b8f5987eb..89308e5e574f 100644 --- a/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java +++ b/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java @@ -85,7 +85,6 @@ public MessageSerializer getMessageSerializer() { @Override public boolean initialize() { - assert (_transportProvider != null); if (_transportProvider == null) return false; From 043ebe377e7b215f9b9793eddd3008231adceff7 Mon Sep 17 00:00:00 2001 From: Rafael da Fonseca Date: Mon, 15 Jun 2015 17:32:00 +0200 Subject: [PATCH 2/2] Re-run travis --- .../src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java | 1 - 1 file changed, 1 deletion(-) diff --git a/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java b/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java index 89308e5e574f..9a5e8c233d93 100644 --- a/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java +++ b/framework/ipc/src/org/apache/cloudstack/framework/rpc/RpcProviderImpl.java @@ -87,7 +87,6 @@ public MessageSerializer getMessageSerializer() { public boolean initialize() { if (_transportProvider == null) return false; - TransportEndpointSite endpointSite = _transportProvider.attach(_transportEndpoint, "RpcProvider"); endpointSite.registerMultiplexier(RPC_MULTIPLEXIER, this); return true;