From 24854df61ac7ee5d5ae95cf6b6114794134e776e Mon Sep 17 00:00:00 2001 From: Jaime Oliveira Date: Mon, 19 Oct 2020 11:08:39 +0200 Subject: [PATCH] fix(@angular-devkit/build-angular): add a base href to karma debug context This commits adds a base href value in the karma context iframe used to run unit tests where a unit test throws: No base href set. Please provide a value for the APP_BASE_HREF token or add a base element to the document. Even if the application is fine. This is because the index.html from Angular CLI contains a base href value, but not the Karma context iframe. So when adding a unit test with a testing module that imports a NgModule, for example AppModule, which itself imports RouterModule, the unit test used to throw an error (regression appeared in router 3.1). That could be solved by either adding `RouterTestingModule` to the testing module, or by adding a provider `{ provide: APP_BASE_HREF, useValue: '/' }`, but required to understand the issue. This solves the issue in a transparent way: developers won't even encounter the problem anymore. Closes #19116 --- .../build_angular/src/webpack/plugins/karma-debug.html | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/angular_devkit/build_angular/src/webpack/plugins/karma-debug.html b/packages/angular_devkit/build_angular/src/webpack/plugins/karma-debug.html index 8c3fe313059d..44dbff5898f4 100644 --- a/packages/angular_devkit/build_angular/src/webpack/plugins/karma-debug.html +++ b/packages/angular_devkit/build_angular/src/webpack/plugins/karma-debug.html @@ -9,6 +9,7 @@ %X_UA_COMPATIBLE% Karma DEBUG RUNNER +