From 4c518ba161fcd14f7f85b654e1981ad77b3569a6 Mon Sep 17 00:00:00 2001 From: SaifAli-S Date: Fri, 13 Nov 2026 23:15:46 +0530 Subject: [PATCH] fix: correct float rounding in num_digits_fast for large integers --- maths/number_of_digits.py | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/maths/number_of_digits.py b/maths/number_of_digits.py index 7eaef2f6d3ca..838a1b81fae9 100644 --- a/maths/number_of_digits.py +++ b/maths/number_of_digits.py @@ -47,6 +47,14 @@ def num_digits_fast(n: int) -> int: 4 >>> num_digits_fast(10**15) 16 + >>> num_digits_fast(10**16 - 1) + 16 + >>> num_digits_fast(10**16) + 17 + >>> num_digits_fast(10**50 - 1) + 50 + >>> num_digits_fast(-(10**16 - 1)) + 16 >>> num_digits_fast(0) 1 >>> num_digits_fast(-1) @@ -60,7 +68,16 @@ def num_digits_fast(n: int) -> int: """ if not isinstance(n, int): raise TypeError("Input must be an integer") - return 1 if n == 0 else math.floor(math.log10(abs(n)) + 1) + if n == 0: + return 1 + + abs_n = abs(n) + digits = math.floor(math.log10(abs_n) + 1) + if abs_n < 10 ** (digits - 1): + digits -= 1 + elif abs_n >= 10**digits: + digits += 1 + return digits def num_digits_faster(n: int) -> int: