diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 34ff6cdc5..71bf61113 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -3,7 +3,7 @@ ### Issue 1. Try [dev](https://github.com/RubaXa/Sortable/tree/dev/)-branch, perhaps the problem has been solved; - 2. [Use the search](https://github.com/RubaXa/Sortable/search?q=problem), maybe already have an answer; + 2. [Use the search](https://github.com/RubaXa/Sortable/search?type=Issues&q=problem), maybe already have an answer; 3. If not found, create example on [jsbin.com (draft)](http://jsbin.com/zunibaxada/1/edit?html,js,output) and describe the problem. --- diff --git a/Sortable.js b/Sortable.js index 75365d7cf..815fca203 100644 --- a/Sortable.js +++ b/Sortable.js @@ -24,6 +24,12 @@ })(function () { "use strict"; + if (typeof window == "undefined" || typeof window.document == "undefined") { + return function() { + throw new Error( "Sortable.js requires a window with a document" ); + } + } + var dragEl, parentEl, ghostEl, @@ -329,7 +335,7 @@ _this._disableDelayedDrag(); // Make the element draggable - dragEl.draggable = true; + dragEl.draggable = _this.nativeDraggable; // Chosen item _toggleClass(dragEl, _this.options.chosenClass, true); diff --git a/knockout-sortable.js b/knockout-sortable.js index dac7f6f37..dcb470a83 100644 --- a/knockout-sortable.js +++ b/knockout-sortable.js @@ -1,16 +1,54 @@ (function (factory) { "use strict"; - if (typeof define === "function" && define.amd) { - // AMD anonymous module - define(["knockout", "./Sortable"], factory); - } else if (typeof require === "function" && typeof exports === "object" && typeof module === "object") { - // CommonJS module - var ko = require("knockout"); - var Sortable = require('./Sortable'); - factory(ko, Sortable); - } else { - // No module loader (plain