From 9f881747bb3fe28c643c92a1fa86d681e83cd3fd Mon Sep 17 00:00:00 2001 From: Claude Date: Tue, 13 Oct 2026 14:32:26 +0000 Subject: [PATCH] Fix flaky npm mirror tarball test `project_registry_decides_a_mirrors_tarball_urls` (added in #1466) checks the default-registry fallback, which reads SOCKET_NPM_REGISTRY. The bun lockb and vlt restore tests set that variable to a mock server, and they are serial, but this test was not, so it could run while one of them held the variable and fail. It knocked #1470 out of the merge queue on the coverage job. Mark it serial like the other tests that depend on the variable. Assisted-by: Claude Code:claude-opus-5-5 --- crates/socket-patch-core/src/patch/redirect/upstream/npm.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/crates/socket-patch-core/src/patch/redirect/upstream/npm.rs b/crates/socket-patch-core/src/patch/redirect/upstream/npm.rs index 156cfcd17..dba7ab4c4 100644 --- a/crates/socket-patch-core/src/patch/redirect/upstream/npm.rs +++ b/crates/socket-patch-core/src/patch/redirect/upstream/npm.rs @@ -4024,7 +4024,10 @@ mod tests { ); } + // Serial: the default-registry fallback reads `SOCKET_NPM_REGISTRY`, + // which the serial bun and vlt restore tests point at a mock server. #[test] + #[serial_test::serial] fn project_registry_decides_a_mirrors_tarball_urls() { // A metadata mirror that hands back the project registry's own URLs: // the package manager derives them, so they stay out of the lock.