From f540a5969513d133c00848585c4288a26827031a Mon Sep 17 00:00:00 2001 From: Ralf Juengling Date: Fri, 20 Nov 2026 19:32:54 -0800 Subject: [PATCH] fix(cuda.core): drop the unsynchronized driver version cache in cy_driver_version cy_driver_version() filled a module-level tuple without synchronization. On free-threaded builds, concurrent first calls could replace the tuple while another thread was reading it, leaking it or releasing it too often. driver_version() is already cached with functools.cache, which is safe under concurrent calls, so cy_driver_version() now returns it directly. --- cuda_core/cuda/core/_utils/version.pyx | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/cuda_core/cuda/core/_utils/version.pyx b/cuda_core/cuda/core/_utils/version.pyx index b92fc5952e3..1ef30b3affb 100644 --- a/cuda_core/cuda/core/_utils/version.pyx +++ b/cuda_core/cuda/core/_utils/version.pyx @@ -46,11 +46,8 @@ def driver_version() -> tuple[int, int, int]: return (ver // 1000, (ver // 10) % 100, ver % 10) -cdef tuple _cached_driver_version = None - - cdef tuple cy_driver_version(): - global _cached_driver_version - if _cached_driver_version is None: - _cached_driver_version = driver_version() - return _cached_driver_version + # Do not add a module-level cache here: it would be filled without + # synchronization, which is unsafe on free-threaded builds. + # functools.cache on driver_version() is. + return driver_version()