fix(plugin): review of 0.101.0 -- an entity registry that throws is logged and the probe pass carries on; v0.101.0

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Author: trial

packages/plugin/src/util/changeProbe.js

@@ -1497,11 +1497,18 @@ export const runProbePass = async ({
 		// THE ENTITY'S CANONICAL, as the origin's endpoint names it now (util/entity.js). Before the baseline
 		// logic, because it is a statement about the origin, not about this row's history: a re-baselined or a
 		// changed row reports its product's canonical all the same. Only from an ARMED mapped field — one the
-		// mapping guard disarmed is suspected of being mapped wrong, and must not file targets.
+		// mapping guard disarmed is suspected of being mapped wrong, and must not file targets. The hook is an
+		// add-on to the pass, so its failure is logged and the row carries on: it must never end the pass.
 		if (onCanonical) {
 			const field = canonicalFieldOf(rule);
 			const slots = field && (!guard || guard.isArmed(rule, field)) ? valuesOf() : null;
-			if (slots) await onCanonical({ url: row.url, value: slots[field.slot] });
+			if (slots) {
+				try {
+					await onCanonical({ url: row.url, value: slots[field.slot] });
+				} catch (e) {
+					logger.warn?.(`[prerender] change-probe: entity registry failed for ${row.url}: ${e?.message ?? String(e)}`);
+				}
+			}
 		}
 
 		// RULE CHANGED, NOT CONTENT. A baseline is only comparable to an observation made the same

packages/plugin/test/changeProbe.test.js

@@ -2820,6 +2820,33 @@ test('the entity registry is told the canonical slot of every probe that answere
 	assert.deepEqual(told, []);
 });
 
+test('an entity registry that throws, synchronously or not, costs the pass nothing', async () => {
+	const signature = await apiSig({ seoUrl: '/product/prd-a/new-spelling.jsp' });
+	for (const fail of [
+		() => {
+			throw new Error('sync');
+		},
+		async () => {
+			throw new Error('async');
+		},
+	]) {
+		const told = [];
+		const onCanonical = (observation) => (observation.url === URL_A ? fail() : told.push(observation.url));
+		const { stats, written } = await runMappedPass({
+			rows: [row(URL_A), row(URL_B)],
+			answers: { [URL_A]: signature, [URL_B]: signature },
+			onCanonical,
+		});
+		assert.deepEqual(told, [URL_B], 'the next row is still probed and reported');
+		assert.deepEqual(
+			written.map(({ url }) => url),
+			[URL_A, URL_B],
+			'the failing row still seeds its baseline'
+		);
+		assert.equal(stats.failed, 0);
+	}
+});
+
 test('CAUGHT UP: the origin changed and the page ALREADY shows the new value -> baseline moves, nothing triggered', async () => {
 	// A cadence render landed after the rename: re-rendering again would buy nothing.
 	const before = await apiSig();