Skip to content

#6319 Improve remote image URL handling - #6320

Merged
sosnovsky merged 7 commits into
masterfrom
issue-6319-improve-remote-image-url-handling
Nov 4, 2026
Merged

#6319 Improve remote image URL handling#6320
sosnovsky merged 7 commits into
masterfrom
issue-6319-improve-remote-image-url-handling

Conversation

@martgil

@martgil martgil commented Oct 20, 2026 •
edited by sosnovsky
Loading

Copy link
Copy Markdown
Collaborator

This PR normalizes encoded remote image paths before applying remote-image safety checks.

Closes #6319

Tests (delete all except exactly one):

  • Tests added or updated

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • if this PR fixes a security issue: I tried to bypass the new fix, and failed (leave unticked if this PR is not a security fix)
  • is documented clearly and usefully, or doesn't need documentation

@martgil
martgil requested a review from sosnovsky as a code owner October 20, 2026 07:32
@martgil

martgil commented Oct 23, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @sosnovsky - This one is ready for a review. Thank you!

sosnovsky
sosnovsky reviewed Oct 30, 2026
View reviewed changes
Comment thread extension/js/common/platform/xss.ts Resolved
@martgil

martgil commented Nov 4, 2026

Copy link
Copy Markdown
Collaborator Author

Hi @sosnovsky - This one is ready for a review. Thank you!

@martgil
martgil requested a review from sosnovsky November 4, 2026 10:20
sosnovsky
sosnovsky approved these changes Nov 4, 2026
View reviewed changes

@sosnovsky sosnovsky left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👍

@sosnovsky
sosnovsky merged commit 9290bff into master Nov 4, 2026
11 checks passed
@sosnovsky
sosnovsky deleted the issue-6319-improve-remote-image-url-handling branch November 4, 2026 14:18
@martgil

martgil commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks Roma 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosnovsky sosnovsky sosnovsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve remote image URL handling

2 participants

@martgil @sosnovsky