From 579894fe3efa54d76a794a6dce321e1b02b4a65f Mon Sep 17 00:00:00 2001 From: G M Date: Wed, 12 Apr 2017 13:53:04 -0700 Subject: [PATCH 1/3] Fix broken politico.com ruleset and add tests; fixes #9000 --- src/chrome/content/rules/Politico.xml | 35 ++++++++++++++++++++++++--- 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/src/chrome/content/rules/Politico.xml b/src/chrome/content/rules/Politico.xml index 45de7bd2c75d..a4fc1557963e 100644 --- a/src/chrome/content/rules/Politico.xml +++ b/src/chrome/content/rules/Politico.xml @@ -19,6 +19,7 @@ - images ᵐ - static ⁵ - static2 ᵐ + - static3 ⁴ - tk ᵐ - www ⁴ @@ -32,9 +33,11 @@ Mixed content: - Images on secure from static2.politico.com ᵐ + - Images on secure from static3.politico.com/dims4/ ⁴ - favicon on secure from static.politico.com ˢ ᵐ Not secured by us <= mismatched + ⁴ 404, equivalent to another domain ˢ Secured by us, see https://www.paulirish.com/2010/the-protocol-relative-url/ --> @@ -51,7 +54,6 @@ - @@ -61,16 +63,41 @@ - + + + + + + + + + + + + + + + + + + + + + + + + + + + to="https://secure.politico.com/" /> + to="https://static3.politico.com/" /> From 4fe61e8fba13504cccee96a29ec654473b09e3af Mon Sep 17 00:00:00 2001 From: G M Date: Thu, 27 Apr 2017 18:23:36 -0700 Subject: [PATCH 2/3] removed non-capturing groups from Politico.xml --- src/chrome/content/rules/Politico.xml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/chrome/content/rules/Politico.xml b/src/chrome/content/rules/Politico.xml index a4fc1557963e..c807bf15694e 100644 --- a/src/chrome/content/rules/Politico.xml +++ b/src/chrome/content/rules/Politico.xml @@ -69,19 +69,19 @@ - + - + - + - + @@ -93,7 +93,7 @@ - Date: Sun, 1 Oct 2017 12:58:10 -0700 Subject: [PATCH 3/3] politico.com: escape dots in exclusion patterns --- src/chrome/content/rules/Politico.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/chrome/content/rules/Politico.xml b/src/chrome/content/rules/Politico.xml index c807bf15694e..2981d6fc5778 100644 --- a/src/chrome/content/rules/Politico.xml +++ b/src/chrome/content/rules/Politico.xml @@ -66,7 +66,7 @@ - + @@ -87,7 +87,7 @@ - +