From 4244b569212c8e4aaf62f6c67eb753c5862745e4 Mon Sep 17 00:00:00 2001 From: Chan Chak Shing Date: Wed, 4 Apr 2018 10:48:25 +0800 Subject: [PATCH 1/3] Add Option UI to Enable mixedcontent Rulesets Globally --- chromium/background-scripts/background.js | 5 +++++ chromium/pages/options/index.html | 12 +++++++++--- chromium/pages/options/style.css | 4 ++++ chromium/pages/options/ux.js | 16 +++++++++++++++- 4 files changed, 33 insertions(+), 4 deletions(-) diff --git a/chromium/background-scripts/background.js b/chromium/background-scripts/background.js index 51cca78d0489..cbe1161e4b96 100644 --- a/chromium/background-scripts/background.js +++ b/chromium/background-scripts/background.js @@ -73,6 +73,11 @@ chrome.storage.onChanged.addListener(async function(changes, areaName) { isExtensionEnabled = changes.globalEnabled.newValue; updateState(); } + if ('enableMixedRulesets' in changes) { + // Don't require users to restart the browsers + rules.settings.enableMixedRulesets = changes.enableMixedRulesets.newValue; + initializeAllRules(); + } if ('debugging_rulesets' in changes) { initializeAllRules(); } diff --git a/chromium/pages/options/index.html b/chromium/pages/options/index.html index d8d72dc3fe06..3e8dbdc842c4 100644 --- a/chromium/pages/options/index.html +++ b/chromium/pages/options/index.html @@ -7,15 +7,21 @@
-
+
- +
-
+
+
+
+ + +
+
diff --git a/chromium/pages/options/style.css b/chromium/pages/options/style.css index 206ad62ca141..9b570806b276 100644 --- a/chromium/pages/options/style.css +++ b/chromium/pages/options/style.css @@ -6,6 +6,10 @@ margin-bottom: 20px; } +.general-settings-wrapper#mixed-rulesets-wrapper{ + margin-bottom: 20px; +} + .section-header{ margin-bottom: 10px; } diff --git a/chromium/pages/options/ux.js b/chromium/pages/options/ux.js index 29f06fe07886..1a380edc4dbf 100644 --- a/chromium/pages/options/ux.js +++ b/chromium/pages/options/ux.js @@ -32,16 +32,30 @@ document.addEventListener("DOMContentLoaded", () => { const showCounter = document.getElementById("showCounter"); const autoUpdateRulesets = document.getElementById("autoUpdateRulesets"); + const enableMixedRulesets = document.getElementById("enableMixedRulesets"); - sendMessage("get_option", { showCounter: true, autoUpdateRulesets: true }, item => { + const defaultOptions = { + showCounter: true, + autoUpdateRulesets: true, + enableMixedRulesets: false, + }; + + sendMessage("get_option", defaultOptions, item => { showCounter.checked = item.showCounter; autoUpdateRulesets.checked = item.autoUpdateRulesets; + enableMixedRulesets.checked = item.enableMixedRulesets; + showCounter.addEventListener("change", () => { sendMessage("set_option", { showCounter: showCounter.checked }); }); + autoUpdateRulesets.addEventListener("change", () => { sendMessage("set_option", { autoUpdateRulesets: autoUpdateRulesets.checked }); }); + + enableMixedRulesets.addEventListener("change", () => { + sendMessage("set_option", { enableMixedRulesets: enableMixedRulesets.checked }); + }) }); document.onkeydown = function(evt) { From eb2eba49e6fc6765a0ee7356910fa9ce0d94a516 Mon Sep 17 00:00:00 2001 From: Chan Chak Shing Date: Wed, 4 Apr 2018 11:53:24 +0800 Subject: [PATCH 2/3] Use getElementById instead of querySelector --- chromium/pages/options/index.html | 2 +- chromium/pages/options/ux.js | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/chromium/pages/options/index.html b/chromium/pages/options/index.html index 3e8dbdc842c4..2c417bd46afb 100644 --- a/chromium/pages/options/index.html +++ b/chromium/pages/options/index.html @@ -24,7 +24,7 @@
- +
diff --git a/chromium/pages/options/ux.js b/chromium/pages/options/ux.js index 1a380edc4dbf..6c38bd01e7ff 100644 --- a/chromium/pages/options/ux.js +++ b/chromium/pages/options/ux.js @@ -5,19 +5,19 @@ document.addEventListener("DOMContentLoaded", () => { let json_data; - let import_button = document.querySelector("#import"); + let import_button = document.getElementById("import"); function import_json(e) { e.preventDefault(); let settings = JSON.parse(json_data); sendMessage("import_settings", settings, () => { - document.querySelector("#import-confirmed").style.display = "block"; - document.querySelector("form").style.display = "none"; + document.getElementById("import-confirmed").style.display = "block"; + document.getElementById("import-settings-form").style.display = "none"; }); } - document.querySelector("#import-settings").addEventListener("change", () => { + document.getElementById("import-settings").addEventListener("change", () => { const file = event.target.files[0]; const reader = new FileReader(); reader.addEventListener("load", event => { @@ -28,7 +28,7 @@ document.addEventListener("DOMContentLoaded", () => { reader.readAsText(file); }); - document.querySelector("form").addEventListener("submit", import_json); + document.getElementById("import-settings-form").addEventListener("submit", import_json); const showCounter = document.getElementById("showCounter"); const autoUpdateRulesets = document.getElementById("autoUpdateRulesets"); From ef823db1a4bd620a03d2e888dd262a9b5a2d6d27 Mon Sep 17 00:00:00 2001 From: Chan Chak Shing Date: Wed, 4 Apr 2018 13:04:09 +0800 Subject: [PATCH 3/3] Update https-everywhere.dtd, Add translations --- src/chrome/locale/en/https-everywhere.dtd | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/chrome/locale/en/https-everywhere.dtd b/src/chrome/locale/en/https-everywhere.dtd index c16099cb1891..1a0e5b0a1c8b 100644 --- a/src/chrome/locale/en/https-everywhere.dtd +++ b/src/chrome/locale/en/https-everywhere.dtd @@ -9,12 +9,14 @@ - + + +