From 53b22d7b94a9518d8331e3f81626809f902ea46f Mon Sep 17 00:00:00 2001 From: Warren Date: Fri, 15 May 2026 06:44:20 +0000 Subject: [PATCH 1/3] ci: remove cancel-in-progress from push.yml to fix dropped downstream ports (HDX-4235) The Push Downstream workflow uses createWorkflowDispatch to mirror each push to main as a downstream EE port. Each run is a single short API call, so there is no benefit to cancelling in-flight runs. The previous `cancel-in-progress: true` setting created a race where a queued run could be cancelled (and silently skipped entirely) instead of running after the active one finished. This dropped the EE port for at least one merge commit: - f6a1d0213127bd845fc4cba47fd70d54ce0874dc (PR #2250, feat(mcp): add event_patterns display type to query tool) which had to be ported manually as hyperdxio/hyperdx-ee#2073. Removing the concurrency block ensures every push to main spawns its own downstream dispatch, even when pushes land close together. --- .github/workflows/push.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index 55c0ba6013..d4389082dd 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -2,9 +2,11 @@ name: Push Downstream on: push: branches: [main] -concurrency: - group: ${{ github.workflow }}-${{ github.ref }} - cancel-in-progress: true +# NOTE: Intentionally no `concurrency` block. Each run is a single short +# `createWorkflowDispatch` API call, so there is no benefit to cancelling +# in-flight runs. A previous `cancel-in-progress: true` setting caused at +# least one push (f6a1d02 / PR #2250) to be skipped entirely under load, +# dropping the EE downstream port. See HDX-4235. jobs: push-downstream: timeout-minutes: 5 From 8b46ca848e99b176a8f69fd7f29f5d119ac94341 Mon Sep 17 00:00:00 2001 From: Warren <5959690+wrn14897@users.noreply.github.com> Date: Sun, 17 May 2026 18:48:48 -0700 Subject: [PATCH 2/3] ci: switch push.yml concurrency to cancel-in-progress: false Keep the concurrency block but queue pending runs instead of cancelling them, so every OSS main commit reliably dispatches downstream in commit order. Setting cancel-in-progress: true caused at least one push (f6a1d02 / PR #2250) to be dropped under load, losing the EE downstream port. Removing the block entirely would allow parallel dispatches and out-of-order processing on the EE side. Refs HDX-4235 --- .github/workflows/push.yml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index d4389082dd..c062a6cf3e 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -2,11 +2,14 @@ name: Push Downstream on: push: branches: [main] -# NOTE: Intentionally no `concurrency` block. Each run is a single short -# `createWorkflowDispatch` API call, so there is no benefit to cancelling -# in-flight runs. A previous `cancel-in-progress: true` setting caused at -# least one push (f6a1d02 / PR #2250) to be skipped entirely under load, -# dropping the EE downstream port. See HDX-4235. +# HDX-4235: cancel-in-progress must be false so every OSS main commit reliably +# dispatches downstream in commit order. Setting to true silently drops pending +# runs when commits land in quick succession — at least one push (f6a1d02 / +# PR #2250) was skipped this way, losing the EE downstream port. Queueing +# pending runs preserves order and prevents drops. +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: false jobs: push-downstream: timeout-minutes: 5 From 8487a73564fbed5fb89030250c6f0989ebdf772e Mon Sep 17 00:00:00 2001 From: Warren <5959690+wrn14897@users.noreply.github.com> Date: Sun, 17 May 2026 18:49:58 -0700 Subject: [PATCH 3/3] ci: drop explanatory comment on push.yml concurrency Refs HDX-4235 --- .github/workflows/push.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml index c062a6cf3e..6a6d882c07 100644 --- a/.github/workflows/push.yml +++ b/.github/workflows/push.yml @@ -2,11 +2,6 @@ name: Push Downstream on: push: branches: [main] -# HDX-4235: cancel-in-progress must be false so every OSS main commit reliably -# dispatches downstream in commit order. Setting to true silently drops pending -# runs when commits land in quick succession — at least one push (f6a1d02 / -# PR #2250) was skipped this way, losing the EE downstream port. Queueing -# pending runs preserves order and prevents drops. concurrency: group: ${{ github.workflow }}-${{ github.ref }} cancel-in-progress: false