diff --git a/packages/api/src/models/source.ts b/packages/api/src/models/source.ts index dc91fb7353..adb3c31c3b 100644 --- a/packages/api/src/models/source.ts +++ b/packages/api/src/models/source.ts @@ -90,11 +90,10 @@ export const Source = mongoose.model( querySettings: { type: [ { - setting: { type: String, required: true }, - value: { type: String, required: true }, + setting: { type: String, required: true, minlength: 1 }, + value: { type: String, required: true, minlength: 1 }, }, ], - default: undefined, maxlength: 10, }, }, diff --git a/packages/app/src/hooks/useChartConfig.tsx b/packages/app/src/hooks/useChartConfig.tsx index 07bb222202..a0d9838b4f 100644 --- a/packages/app/src/hooks/useChartConfig.tsx +++ b/packages/app/src/hooks/useChartConfig.tsx @@ -5,7 +5,6 @@ import { ResponseJSON, } from '@hyperdx/common-utils/dist/clickhouse'; import { ClickhouseClient } from '@hyperdx/common-utils/dist/clickhouse/browser'; -import { tryOptimizeConfigWithMaterializedView } from '@hyperdx/common-utils/dist/core/materializedViews'; import { Metadata } from '@hyperdx/common-utils/dist/core/metadata'; import { isMetricChartConfig, @@ -397,10 +396,6 @@ export function useAliasMapFromChartConfig( const metadata = useMetadataWithSettings(); - const { data: source, isLoading: isSourceLoading } = useSource({ - id: config?.source, - }); - return useQuery>({ // Only include config properties that affect SELECT structure and aliases. // When adding new ChartConfig fields, check renderChartConfig.ts to see if they @@ -432,7 +427,7 @@ export function useAliasMapFromChartConfig( return aliasMap; }, - enabled: config != null && !isSourceLoading, + enabled: config != null, ...options, }); } diff --git a/packages/common-utils/src/types.ts b/packages/common-utils/src/types.ts index 2712811d4b..80e2c2fedf 100644 --- a/packages/common-utils/src/types.ts +++ b/packages/common-utils/src/types.ts @@ -604,7 +604,7 @@ export enum SourceKind { // -------------------------- const QuerySettingsSchema = z.array( - z.object({ setting: z.string(), value: z.string() }), + z.object({ setting: z.string().min(1), value: z.string().min(1) }), ); export type QuerySettings = z.infer;