From 95f6ded3a399c3df535d293670ad5c6a582214a8 Mon Sep 17 00:00:00 2001 From: GBKS Date: Fri, 19 Mar 2021 09:15:39 +0100 Subject: [PATCH 1/2] Fixes visual glitch on the formatting page See issue #183 for the description. Problem was a mismatch of responsive breakpoints used for page-wide and component-specific padding and margin. --- _sass/minima/_article.scss | 18 ++++++++++++------ guide/contribute/formatting.md | 1 + 2 files changed, 13 insertions(+), 6 deletions(-) diff --git a/_sass/minima/_article.scss b/_sass/minima/_article.scss index 2c656cd04..e8995da5f 100644 --- a/_sass/minima/_article.scss +++ b/_sass/minima/_article.scss @@ -197,7 +197,7 @@ article.guide { &:hover { text-decoration: none; - } + } } @include media-query(large) { @@ -214,7 +214,7 @@ article.guide { a.header-anchor { opacity: 1; } - } + } } } @@ -432,8 +432,6 @@ article.guide { } @include media-query(small) { - margin-left: -15px; - margin-right: -15px; padding: 30px 0; figure { @@ -450,9 +448,12 @@ article.guide { } } + @include media-query(medium-down) { + margin-left: -15px; + margin-right: -15px; + } + @include media-query(medium-up) { - margin-left: -30px; - margin-right: -30px; padding: 30px 0 30px 0; figure { @@ -466,6 +467,11 @@ article.guide { flex-basis: 30px; } } + + @include media-query(large) { + margin-left: -30px; + margin-right: -30px; + } } & > .-float-right, diff --git a/guide/contribute/formatting.md b/guide/contribute/formatting.md index 7d828e5f0..32e9e5c76 100644 --- a/guide/contribute/formatting.md +++ b/guide/contribute/formatting.md @@ -6,6 +6,7 @@ nav_order: 5 parent: Contribute to guide permalink: /guide/contribute/formatting/ image: /assets/images/guide/contribute/formatting-preview.jpg +main_classes: -no-top-padding --- # Formatting From 9e9178d3094b3559d321db5c24892de0b70f34c0 Mon Sep 17 00:00:00 2001 From: GBKS Date: Mon, 22 Mar 2021 10:21:02 +0100 Subject: [PATCH 2/2] Fixing layout issue on iPad Pro sized screens Issue was due to "pre" tags that contain longer lines of code busting out of the containing element. --- _sass/minima/_layout.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/_sass/minima/_layout.scss b/_sass/minima/_layout.scss index 19ace2c45..017ff7ba3 100644 --- a/_sass/minima/_layout.scss +++ b/_sass/minima/_layout.scss @@ -20,6 +20,7 @@ flex-shrink: 1; border-left: 1px solid rgba(var(--front), 0.1); min-height: 90vh; + overflow: hidden; .edit-link { max-width: 800px; @@ -179,7 +180,7 @@ article.guide h1 { article.guide { h1 { margin-top: $spacing-unit * 1; - + @include media-query(medium-up) { margin-top: $spacing-unit * 2; }